[Sema] Sink Pattern invalidation into SyntacticElementTarget::markInvalid
#83633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this currently affects anything, but match what we do for the expression and update the pattern if type-checking the initialization fails.
…valid` Rather than handling this in the callers of `typeCheckExpression`, handle it in the constraint system's invalidation logic. This also ensures we set a type for sub-pattern nodes.
I don't recall why I made this conditional, let's just be consistent and always set ErrorType for invalid AST. This should only affect things like implicit nodes.
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
xedin
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than handling this in the callers of
typeCheckExpression, handle it in the constraint system's invalidation logic. This also ensures we set a type for sub-pattern nodes.